| # | File | Line | Problem |
| 1 |
src/com/wjholden/nmap/Nmap.java |
1 |
A high number of imports can indicate a high degree of coupling within an object. |
| 2 |
src/com/wjholden/nmap/Nmap.java |
47 |
The class 'Nmap' has a Cyclomatic Complexity of 7 (Highest = 45). |
| 3 |
src/com/wjholden/nmap/Nmap.java |
47 |
This class has too many methods, consider refactoring it. |
| 4 |
src/com/wjholden/nmap/Nmap.java |
47 |
Too many fields |
| 5 |
src/com/wjholden/nmap/Nmap.java |
51 |
Found non-transient, non-static member. Please mark as transient or provide accessors. |
| 6 |
src/com/wjholden/nmap/Nmap.java |
56 |
Found non-transient, non-static member. Please mark as transient or provide accessors. |
| 7 |
src/com/wjholden/nmap/Nmap.java |
61 |
Found non-transient, non-static member. Please mark as transient or provide accessors. |
| 8 |
src/com/wjholden/nmap/Nmap.java |
66 |
Found non-transient, non-static member. Please mark as transient or provide accessors. |
| 9 |
src/com/wjholden/nmap/Nmap.java |
71 |
Found non-transient, non-static member. Please mark as transient or provide accessors. |
| 10 |
src/com/wjholden/nmap/Nmap.java |
71 |
Perhaps 'mHelp' could be replaced by a local variable. |
| 11 |
src/com/wjholden/nmap/Nmap.java |
76 |
Perhaps 'mShare' could be replaced by a local variable. |
| 12 |
src/com/wjholden/nmap/Nmap.java |
94 |
Avoid excessively long variable names like installationVerified |
| 13 |
src/com/wjholden/nmap/Nmap.java |
114 |
Avoid variables with short names like sh |
| 14 |
src/com/wjholden/nmap/Nmap.java |
140 |
Avoid variables with short names like h |
| 15 |
src/com/wjholden/nmap/Nmap.java |
147 |
Avoid variables with short names like pd |
| 16 |
src/com/wjholden/nmap/Nmap.java |
157 |
Perhaps 'preferencesEditor' could be replaced by a local variable. |
| 17 |
src/com/wjholden/nmap/Nmap.java |
165 |
The field name indicates a constant but its modifiers do not |
| 18 |
src/com/wjholden/nmap/Nmap.java |
165 |
Variables should start with a lowercase character |
| 19 |
src/com/wjholden/nmap/Nmap.java |
171 |
Avoid variables with short names like ne |
| 20 |
src/com/wjholden/nmap/Nmap.java |
176 |
Perhaps 'wifiManager' could be replaced by a local variable. |
| 21 |
src/com/wjholden/nmap/Nmap.java |
181 |
Perhaps 'wifiInfo' could be replaced by a local variable. |
| 22 |
src/com/wjholden/nmap/Nmap.java |
184 |
Avoid excessively long variable names like savedInstanceState |
| 23 |
src/com/wjholden/nmap/Nmap.java |
184 |
Avoid really long methods. |
| 24 |
src/com/wjholden/nmap/Nmap.java |
184 |
Parameter 'savedInstanceState' is not assigned and could be declared final |
| 25 |
src/com/wjholden/nmap/Nmap.java |
184 |
The method 'onCreate' has a Cyclomatic Complexity of 45. |
| 26 |
src/com/wjholden/nmap/Nmap.java |
184 |
The method onCreate() has an NPath complexity of 826200 |
| 27 |
src/com/wjholden/nmap/Nmap.java |
198 |
Local variable 'adapterCommand' could be declared final |
| 28 |
src/com/wjholden/nmap/Nmap.java |
206 |
Parameter 'arg0' is not assigned and could be declared final |
| 29 |
src/com/wjholden/nmap/Nmap.java |
206 |
Parameter 'arg1' is not assigned and could be declared final |
| 30 |
src/com/wjholden/nmap/Nmap.java |
207 |
Parameter 'arg2' is not assigned and could be declared final |
| 31 |
src/com/wjholden/nmap/Nmap.java |
207 |
Parameter 'arg3' is not assigned and could be declared final |
| 32 |
src/com/wjholden/nmap/Nmap.java |
222 |
Local variable 'adapterOutput' could be declared final |
| 33 |
src/com/wjholden/nmap/Nmap.java |
246 |
Local variable 'target' could be declared final |
| 34 |
src/com/wjholden/nmap/Nmap.java |
250 |
Local variable 'args' could be declared final |
| 35 |
src/com/wjholden/nmap/Nmap.java |
255 |
Local variable 'result' could be declared final |
| 36 |
src/com/wjholden/nmap/Nmap.java |
258 |
The String literal "installationVerified" appears 4 times in this file; the first occurrence is on line 258 |
| 37 |
src/com/wjholden/nmap/Nmap.java |
260 |
The String literal "hasRunOneScan" appears 4 times in this file; the first occurrence is on line 260 |
| 38 |
src/com/wjholden/nmap/Nmap.java |
262 |
The String literal "canGetRoot" appears 4 times in this file; the first occurrence is on line 262 |
| 39 |
src/com/wjholden/nmap/Nmap.java |
301 |
Avoid variables with short names like ip |
| 40 |
src/com/wjholden/nmap/Nmap.java |
302 |
Avoid using if statements without curly braces |
| 41 |
src/com/wjholden/nmap/Nmap.java |
311 |
The method 'handleMessage' has a Cyclomatic Complexity of 15. |
| 42 |
src/com/wjholden/nmap/Nmap.java |
313 |
Found 'DU'-anomaly for variable 'alert' (lines '313'-'484'). |
| 43 |
src/com/wjholden/nmap/Nmap.java |
313 |
Found 'DU'-anomaly for variable 'alert' (lines '313'-'484'). |
| 44 |
src/com/wjholden/nmap/Nmap.java |
313 |
Found 'DU'-anomaly for variable 'alert' (lines '313'-'484'). |
| 45 |
src/com/wjholden/nmap/Nmap.java |
313 |
Found 'DU'-anomaly for variable 'alert' (lines '313'-'484'). |
| 46 |
src/com/wjholden/nmap/Nmap.java |
313 |
Found 'DU'-anomaly for variable 'alert' (lines '313'-'484'). |
| 47 |
src/com/wjholden/nmap/Nmap.java |
313 |
Found 'DU'-anomaly for variable 'alert' (lines '313'-'484'). |
| 48 |
src/com/wjholden/nmap/Nmap.java |
313 |
Found 'DU'-anomaly for variable 'alert' (lines '313'-'484'). |
| 49 |
src/com/wjholden/nmap/Nmap.java |
313 |
Found 'DU'-anomaly for variable 'alert' (lines '313'-'484'). |
| 50 |
src/com/wjholden/nmap/Nmap.java |
313 |
Found 'DU'-anomaly for variable 'alert' (lines '313'-'484'). |
| 51 |
src/com/wjholden/nmap/Nmap.java |
313 |
Found 'DU'-anomaly for variable 'alert' (lines '313'-'484'). |
| 52 |
src/com/wjholden/nmap/Nmap.java |
319 |
An empty statement (semicolon) not part of a loop |
| 53 |
src/com/wjholden/nmap/Nmap.java |
321 |
Avoid if (x != y) ..; else ..; |
| 54 |
src/com/wjholden/nmap/Nmap.java |
322 |
Avoid using if...else statements without curly braces |
| 55 |
src/com/wjholden/nmap/Nmap.java |
324 |
Avoid using if...else statements without curly braces |
| 56 |
src/com/wjholden/nmap/Nmap.java |
347 |
Position literals first in String comparisons |
| 57 |
src/com/wjholden/nmap/Nmap.java |
348 |
Avoid using if...else statements without curly braces |
| 58 |
src/com/wjholden/nmap/Nmap.java |
349 |
Position literals first in String comparisons |
| 59 |
src/com/wjholden/nmap/Nmap.java |
350 |
Avoid using if...else statements without curly braces |
| 60 |
src/com/wjholden/nmap/Nmap.java |
351 |
Position literals first in String comparisons |
| 61 |
src/com/wjholden/nmap/Nmap.java |
352 |
Avoid using if...else statements without curly braces |
| 62 |
src/com/wjholden/nmap/Nmap.java |
360 |
Avoid assignments in operands |
| 63 |
src/com/wjholden/nmap/Nmap.java |
360 |
Found 'DU'-anomaly for variable 'l' (lines '360'-'484'). |
| 64 |
src/com/wjholden/nmap/Nmap.java |
360 |
Found 'DU'-anomaly for variable 'l' (lines '360'-'484'). |
| 65 |
src/com/wjholden/nmap/Nmap.java |
360 |
Found 'DU'-anomaly for variable 'l' (lines '360'-'484'). |
| 66 |
src/com/wjholden/nmap/Nmap.java |
360 |
Found 'DU'-anomaly for variable 'l' (lines '360'-'484'). |
| 67 |
src/com/wjholden/nmap/Nmap.java |
360 |
Found 'DU'-anomaly for variable 'l' (lines '360'-'484'). |
| 68 |
src/com/wjholden/nmap/Nmap.java |
360 |
Found 'DU'-anomaly for variable 'l' (lines '360'-'484'). |
| 69 |
src/com/wjholden/nmap/Nmap.java |
360 |
Found 'DU'-anomaly for variable 'l' (lines '360'-'484'). |
| 70 |
src/com/wjholden/nmap/Nmap.java |
360 |
Found 'DU'-anomaly for variable 'l' (lines '360'-'484'). |
| 71 |
src/com/wjholden/nmap/Nmap.java |
360 |
Found 'DU'-anomaly for variable 'l' (lines '360'-'484'). |
| 72 |
src/com/wjholden/nmap/Nmap.java |
360 |
Found 'DU'-anomaly for variable 'l' (lines '360'-'484'). |
| 73 |
src/com/wjholden/nmap/Nmap.java |
424 |
Avoid using if statements without curly braces |
| 74 |
src/com/wjholden/nmap/Nmap.java |
425 |
Found 'DU'-anomaly for variable 's' (lines '425'-'484'). |
| 75 |
src/com/wjholden/nmap/Nmap.java |
425 |
Found 'DU'-anomaly for variable 's' (lines '425'-'484'). |
| 76 |
src/com/wjholden/nmap/Nmap.java |
425 |
Found 'DU'-anomaly for variable 's' (lines '425'-'484'). |
| 77 |
src/com/wjholden/nmap/Nmap.java |
425 |
Found 'DU'-anomaly for variable 's' (lines '425'-'484'). |
| 78 |
src/com/wjholden/nmap/Nmap.java |
425 |
Found 'DU'-anomaly for variable 's' (lines '425'-'484'). |
| 79 |
src/com/wjholden/nmap/Nmap.java |
425 |
Found 'DU'-anomaly for variable 's' (lines '425'-'484'). |
| 80 |
src/com/wjholden/nmap/Nmap.java |
425 |
Found 'DU'-anomaly for variable 's' (lines '425'-'484'). |
| 81 |
src/com/wjholden/nmap/Nmap.java |
425 |
Found 'DU'-anomaly for variable 's' (lines '425'-'484'). |
| 82 |
src/com/wjholden/nmap/Nmap.java |
425 |
Found 'DU'-anomaly for variable 's' (lines '425'-'484'). |
| 83 |
src/com/wjholden/nmap/Nmap.java |
425 |
Found 'DU'-anomaly for variable 's' (lines '425'-'484'). |
| 84 |
src/com/wjholden/nmap/Nmap.java |
488 |
Avoid instantiating String objects; this is usually unnecessary. |
| 85 |
src/com/wjholden/nmap/Nmap.java |
493 |
Avoid instantiating String objects; this is usually unnecessary. |
| 86 |
src/com/wjholden/nmap/Nmap.java |
498 |
Avoid using if statements without curly braces |
| 87 |
src/com/wjholden/nmap/Nmap.java |
500 |
Avoid using if statements without curly braces |
| 88 |
src/com/wjholden/nmap/Nmap.java |
506 |
Avoid excessively long variable names like savedInstanceState |
| 89 |
src/com/wjholden/nmap/Nmap.java |
514 |
Avoid using if statements without curly braces |
| 90 |
src/com/wjholden/nmap/Nmap.java |
578 |
Use bitwise inversion to invert boolean values |
| 91 |
src/com/wjholden/nmap/NmapError.java |
21 |
Avoid using implementation types like 'ArrayList'; use the interface instead |
| 92 |
src/com/wjholden/nmap/NmapError.java |
21 |
Avoid using implementation types like 'ArrayList'; use the interface instead |
| 93 |
src/com/wjholden/nmap/NmapError.java |
21 |
Found non-transient, non-static member. Please mark as transient or provide accessors. |
| 94 |
src/com/wjholden/nmap/NmapError.java |
21 |
Private field 'errors' could be made final; it is only initialized in the declaration or constructor. |
| 95 |
src/com/wjholden/nmap/NmapError.java |
33 |
Avoid variables with short names like s |
| 96 |
src/com/wjholden/nmap/NmapError.java |
33 |
Method names should not start with capital letters |
| 97 |
src/com/wjholden/nmap/NmapError.java |
33 |
Parameter 's' is not assigned and could be declared final |
| 98 |
src/com/wjholden/nmap/NmapError.java |
42 |
Avoid using if statements without curly braces |
| 99 |
src/com/wjholden/nmap/NmapError.java |
50 |
Method names should not start with capital letters |
| 100 |
src/com/wjholden/nmap/NmapError.java |
52 |
Avoid variables with short names like s |
| 101 |
src/com/wjholden/nmap/NmapError.java |
53 |
Local variable 'stop' could be declared final |
| 102 |
src/com/wjholden/nmap/NmapError.java |
56 |
Prefer StringBuffer over += for concatenating strings |
| 103 |
src/com/wjholden/nmap/NmapUtilities.java |
18 |
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
| 104 |
src/com/wjholden/nmap/NmapUtilities.java |
27 |
Avoid variables with short names like c |
| 105 |
src/com/wjholden/nmap/NmapUtilities.java |
27 |
Parameter 'c' is not assigned and could be declared final |
| 106 |
src/com/wjholden/nmap/NmapUtilities.java |
29 |
Local variable 'tmpdir' could be declared final |
| 107 |
src/com/wjholden/nmap/NmapUtilities.java |
46 |
Local variable 'msg' could be declared final |
| 108 |
src/com/wjholden/nmap/NmapUtilities.java |
65 |
Local variable 'path' could be declared final |
| 109 |
src/com/wjholden/nmap/NmapUtilities.java |
66 |
Avoid variables with short names like st |
| 110 |
src/com/wjholden/nmap/NmapUtilities.java |
66 |
Local variable 'st' could be declared final |
| 111 |
src/com/wjholden/nmap/NmapUtilities.java |
69 |
Local variable 'token' could be declared final |
| 112 |
src/com/wjholden/nmap/NmapUtilities.java |
70 |
Avoid instantiating new objects inside loops |
| 113 |
src/com/wjholden/nmap/NmapUtilities.java |
76 |
A method should have only one exit point, and that should be the last statement in the method |
| 114 |
src/com/wjholden/nmap/NmapUtilities.java |
76 |
This statement may have some unnecessary parentheses |
| 115 |
src/com/wjholden/nmap/NmapUtilities.java |
84 |
This statement may have some unnecessary parentheses |
| 116 |
src/com/wjholden/nmap/NmapUtilities.java |
92 |
Avoid variables with short names like c |
| 117 |
src/com/wjholden/nmap/NmapUtilities.java |
92 |
Parameter 'c' is not assigned and could be declared final |
| 118 |
src/com/wjholden/nmap/NmapUtilities.java |
95 |
A method should have only one exit point, and that should be the last statement in the method |
| 119 |
src/com/wjholden/nmap/NmapUtilities.java |
95 |
This statement may have some unnecessary parentheses |
| 120 |
src/com/wjholden/nmap/NmapUtilities.java |
98 |
This statement may have some unnecessary parentheses |
| 121 |
src/com/wjholden/nmap/NmapUtilities.java |
109 |
Parameter 'myDataDir' is not assigned and could be declared final |
| 122 |
src/com/wjholden/nmap/NmapUtilities.java |
119 |
This statement may have some unnecessary parentheses |
| 123 |
src/com/wjholden/nmap/Nmap_Constants.java |
12 |
An Interface should be used only to model a behaviour; consider converting this to a class. |
| 124 |
src/com/wjholden/nmap/Nmap_Constants.java |
16 |
Avoid modifiers which are implied by the context |
| 125 |
src/com/wjholden/nmap/Nmap_Constants.java |
21 |
Avoid modifiers which are implied by the context |
| 126 |
src/com/wjholden/nmap/Nmap_Constants.java |
26 |
Avoid modifiers which are implied by the context |
| 127 |
src/com/wjholden/nmap/Nmap_Constants.java |
31 |
Avoid modifiers which are implied by the context |
| 128 |
src/com/wjholden/nmap/Nmap_Constants.java |
36 |
Avoid modifiers which are implied by the context |
| 129 |
src/com/wjholden/nmap/Nmap_Constants.java |
55 |
Avoid excessively long variable names like MENU_ITEM_DEBUG_ENABLE |
| 130 |
src/com/wjholden/nmap/Nmap_Constants.java |
56 |
Avoid excessively long variable names like MENU_ITEM_DEBUG_EMAIL |
| 131 |
src/com/wjholden/nmap/Nmap_Constants.java |
57 |
Avoid excessively long variable names like MENU_ITEM_MORE_HELP |
| 132 |
src/com/wjholden/nmap/Nmap_Constants.java |
58 |
Avoid excessively long variable names like MENU_ITEM_REINSTALL |
| 133 |
src/com/wjholden/nmap/Nmap_Constants.java |
62 |
Avoid excessively long variable names like MENU_GROUP_EXTRA_OPTIONS |
| 134 |
src/com/wjholden/nmap/scan.java |
25 |
Class names should begin with an uppercase character |
| 135 |
src/com/wjholden/nmap/scan.java |
25 |
The class 'scan' has a Cyclomatic Complexity of 10 (Highest = 20). |
| 136 |
src/com/wjholden/nmap/scan.java |
27 |
Found non-transient, non-static member. Please mark as transient or provide accessors. |
| 137 |
src/com/wjholden/nmap/scan.java |
28 |
Avoid excessively long variable names like executionParameters |
| 138 |
src/com/wjholden/nmap/scan.java |
28 |
Found non-transient, non-static member. Please mark as transient or provide accessors. |
| 139 |
src/com/wjholden/nmap/scan.java |
28 |
Perhaps 'executionParameters' could be replaced by a local variable. |
| 140 |
src/com/wjholden/nmap/scan.java |
29 |
Avoid variables with short names like c |
| 141 |
src/com/wjholden/nmap/scan.java |
29 |
Found non-transient, non-static member. Please mark as transient or provide accessors. |
| 142 |
src/com/wjholden/nmap/scan.java |
29 |
Perhaps 'c' could be replaced by a local variable. |
| 143 |
src/com/wjholden/nmap/scan.java |
31 |
Avoid variables with short names like os |
| 144 |
src/com/wjholden/nmap/scan.java |
31 |
Found non-transient, non-static member. Please mark as transient or provide accessors. |
| 145 |
src/com/wjholden/nmap/scan.java |
31 |
Perhaps 'os' could be replaced by a local variable. |
| 146 |
src/com/wjholden/nmap/scan.java |
32 |
Avoid variables with short names like in |
| 147 |
src/com/wjholden/nmap/scan.java |
32 |
Found non-transient, non-static member. Please mark as transient or provide accessors. |
| 148 |
src/com/wjholden/nmap/scan.java |
32 |
Perhaps 'in' could be replaced by a local variable. |
| 149 |
src/com/wjholden/nmap/scan.java |
33 |
Perhaps 'err' could be replaced by a local variable. |
| 150 |
src/com/wjholden/nmap/scan.java |
34 |
Avoid variables with short names like p |
| 151 |
src/com/wjholden/nmap/scan.java |
38 |
Switch statements should have a default label |
| 152 |
src/com/wjholden/nmap/scan.java |
41 |
Avoid instantiating String objects; this is usually unnecessary. |
| 153 |
src/com/wjholden/nmap/scan.java |
68 |
Avoid variables with short names like v |
| 154 |
src/com/wjholden/nmap/scan.java |
68 |
Parameter 'v' is not assigned and could be declared final |
| 155 |
src/com/wjholden/nmap/scan.java |
78 |
Avoid really long methods. |
| 156 |
src/com/wjholden/nmap/scan.java |
78 |
Parameter 'params' is not assigned and could be declared final |
| 157 |
src/com/wjholden/nmap/scan.java |
78 |
The method 'doInBackground' has a Cyclomatic Complexity of 20. |
| 158 |
src/com/wjholden/nmap/scan.java |
78 |
The method doInBackground() has an NPath complexity of 59904 |
| 159 |
src/com/wjholden/nmap/scan.java |
82 |
Avoid using if statements without curly braces |
| 160 |
src/com/wjholden/nmap/scan.java |
102 |
Local variable 'msg' could be declared final |
| 161 |
src/com/wjholden/nmap/scan.java |
106 |
A method should have only one exit point, and that should be the last statement in the method |
| 162 |
src/com/wjholden/nmap/scan.java |
106 |
This statement may have some unnecessary parentheses |
| 163 |
src/com/wjholden/nmap/scan.java |
109 |
Avoid using if...else statements without curly braces |
| 164 |
src/com/wjholden/nmap/scan.java |
113 |
Local variable 'msg' could be declared final |
| 165 |
src/com/wjholden/nmap/scan.java |
117 |
A method should have only one exit point, and that should be the last statement in the method |
| 166 |
src/com/wjholden/nmap/scan.java |
117 |
This statement may have some unnecessary parentheses |
| 167 |
src/com/wjholden/nmap/scan.java |
124 |
Avoid using if statements without curly braces |
| 168 |
src/com/wjholden/nmap/scan.java |
126 |
Avoid using if statements without curly braces |
| 169 |
src/com/wjholden/nmap/scan.java |
128 |
Avoid using if statements without curly braces |
| 170 |
src/com/wjholden/nmap/scan.java |
139 |
Position literals first in String comparisons |
| 171 |
src/com/wjholden/nmap/scan.java |
140 |
Avoid using if...else statements without curly braces |
| 172 |
src/com/wjholden/nmap/scan.java |
172 |
Avoid assignments in operands |
| 173 |
src/com/wjholden/nmap/scan.java |
175 |
Prefer StringBuffer over += for concatenating strings |
| 174 |
src/com/wjholden/nmap/scan.java |
179 |
Local variable 'msg1' could be declared final |
| 175 |
src/com/wjholden/nmap/scan.java |
186 |
Local variable 'msg' could be declared final |
| 176 |
src/com/wjholden/nmap/scan.java |
194 |
Avoid assignments in operands |
| 177 |
src/com/wjholden/nmap/scan.java |
196 |
Local variable 'msg' could be declared final |
| 178 |
src/com/wjholden/nmap/scan.java |
219 |
Avoid using if statements without curly braces |
| 179 |
src/com/wjholden/nmap/scan.java |
219 |
Position literals first in String comparisons |
| 180 |
src/com/wjholden/nmap/scan.java |
221 |
This statement may have some unnecessary parentheses |
| 181 |
src/com/wjholden/nmap/verifyInstallation.java |
28 |
Class names should begin with an uppercase character |
| 182 |
src/com/wjholden/nmap/verifyInstallation.java |
28 |
The class 'verifyInstallation' has a Cyclomatic Complexity of 8 (Highest = 20). |
| 183 |
src/com/wjholden/nmap/verifyInstallation.java |
33 |
Avoid excessively long variable names like installationResults |
| 184 |
src/com/wjholden/nmap/verifyInstallation.java |
33 |
Found non-transient, non-static member. Please mark as transient or provide accessors. |
| 185 |
src/com/wjholden/nmap/verifyInstallation.java |
38 |
Found non-transient, non-static member. Please mark as transient or provide accessors. |
| 186 |
src/com/wjholden/nmap/verifyInstallation.java |
38 |
Private field 'filenames' could be made final; it is only initialized in the declaration or constructor. |
| 187 |
src/com/wjholden/nmap/verifyInstallation.java |
43 |
Found non-transient, non-static member. Please mark as transient or provide accessors. |
| 188 |
src/com/wjholden/nmap/verifyInstallation.java |
43 |
Private field 'requiredResources' could be made final; it is only initialized in the declaration or constructor. |
| 189 |
src/com/wjholden/nmap/verifyInstallation.java |
48 |
Found non-transient, non-static member. Please mark as transient or provide accessors. |
| 190 |
src/com/wjholden/nmap/verifyInstallation.java |
50 |
Found non-transient, non-static member. Please mark as transient or provide accessors. |
| 191 |
src/com/wjholden/nmap/verifyInstallation.java |
50 |
Perhaps 'resources' could be replaced by a local variable. |
| 192 |
src/com/wjholden/nmap/verifyInstallation.java |
52 |
Avoid variables with short names like v |
| 193 |
src/com/wjholden/nmap/verifyInstallation.java |
52 |
Parameter 'v' is not assigned and could be declared final |
| 194 |
src/com/wjholden/nmap/verifyInstallation.java |
59 |
Avoid really long methods. |
| 195 |
src/com/wjholden/nmap/verifyInstallation.java |
59 |
Parameter 'params' is not assigned and could be declared final |
| 196 |
src/com/wjholden/nmap/verifyInstallation.java |
59 |
The method 'doInBackground' has a Cyclomatic Complexity of 20. |
| 197 |
src/com/wjholden/nmap/verifyInstallation.java |
59 |
The method doInBackground() has an NCSS line count of 102 |
| 198 |
src/com/wjholden/nmap/verifyInstallation.java |
59 |
The method doInBackground() has an NPath complexity of 43920 |
| 199 |
src/com/wjholden/nmap/verifyInstallation.java |
61 |
Found 'DU'-anomaly for variable 'buf' (lines '61'-'244'). |
| 200 |
src/com/wjholden/nmap/verifyInstallation.java |
61 |
Local variable 'buf' could be declared final |
| 201 |
src/com/wjholden/nmap/verifyInstallation.java |
62 |
Avoid if (x != y) ..; else ..; |
| 202 |
src/com/wjholden/nmap/verifyInstallation.java |
63 |
Avoid using if...else statements without curly braces |
| 203 |
src/com/wjholden/nmap/verifyInstallation.java |
65 |
A method should have only one exit point, and that should be the last statement in the method |
| 204 |
src/com/wjholden/nmap/verifyInstallation.java |
65 |
Avoid using if...else statements without curly braces |
| 205 |
src/com/wjholden/nmap/verifyInstallation.java |
75 |
Local variable 'in_nmap_a' could be declared final |
| 206 |
src/com/wjholden/nmap/verifyInstallation.java |
76 |
Local variable 'in_nmap_b' could be declared final |
| 207 |
src/com/wjholden/nmap/verifyInstallation.java |
77 |
Local variable 'in_nmap_c' could be declared final |
| 208 |
src/com/wjholden/nmap/verifyInstallation.java |
78 |
Local variable 'out_nmap' could be declared final |
| 209 |
src/com/wjholden/nmap/verifyInstallation.java |
102 |
A method should have only one exit point, and that should be the last statement in the method |
| 210 |
src/com/wjholden/nmap/verifyInstallation.java |
102 |
This statement may have some unnecessary parentheses |
| 211 |
src/com/wjholden/nmap/verifyInstallation.java |
113 |
Avoid using while statements without curly braces |
| 212 |
src/com/wjholden/nmap/verifyInstallation.java |
116 |
Avoid using while statements without curly braces |
| 213 |
src/com/wjholden/nmap/verifyInstallation.java |
127 |
A method should have only one exit point, and that should be the last statement in the method |
| 214 |
src/com/wjholden/nmap/verifyInstallation.java |
127 |
This statement may have some unnecessary parentheses |
| 215 |
src/com/wjholden/nmap/verifyInstallation.java |
138 |
Avoid instantiating new objects inside loops |
| 216 |
src/com/wjholden/nmap/verifyInstallation.java |
152 |
A method should have only one exit point, and that should be the last statement in the method |
| 217 |
src/com/wjholden/nmap/verifyInstallation.java |
152 |
This statement may have some unnecessary parentheses |
| 218 |
src/com/wjholden/nmap/verifyInstallation.java |
162 |
Avoid variables with short names like p |
| 219 |
src/com/wjholden/nmap/verifyInstallation.java |
163 |
Avoid variables with short names like os |
| 220 |
src/com/wjholden/nmap/verifyInstallation.java |
164 |
Avoid variables with short names like in |
| 221 |
src/com/wjholden/nmap/verifyInstallation.java |
201 |
Avoid variables with short names like e |
| 222 |
src/com/wjholden/nmap/verifyInstallation.java |
202 |
Avoid assignments in operands |
| 223 |
src/com/wjholden/nmap/verifyInstallation.java |
206 |
Avoid assignments in operands |
| 224 |
src/com/wjholden/nmap/verifyInstallation.java |
231 |
A method should have only one exit point, and that should be the last statement in the method |
| 225 |
src/com/wjholden/nmap/verifyInstallation.java |
231 |
This statement may have some unnecessary parentheses |
| 226 |
src/com/wjholden/nmap/verifyInstallation.java |
237 |
This statement may have some unnecessary parentheses |
| 227 |
src/com/wjholden/nmap/verifyInstallation.java |
246 |
Parameter 'path' is not assigned and could be declared final |