PMD

src/com/wjholden/nmap/NmapConstants.java
12 | An Interface should be used only to model a behaviour; consider converting this to a class.
68 | Avoid excessively long variable names like MENU_ITEM_DEBUG_ENABLE
73 | Avoid excessively long variable names like MENU_ITEM_DEBUG_EMAIL
78 | Avoid excessively long variable names like MENU_ITEM_MORE_HELP
83 | Avoid excessively long variable names like MENU_ITEM_REINSTALL
91 | Avoid excessively long variable names like MENU_GROUP_EXTRA_OPTIONS

src/com/wjholden/nmap/NmapInstall.java
33 | Found non-transient, non-static member. Please mark as transient or provide accessors.
41 | Found non-transient, non-static member. Please mark as transient or provide accessors.
49 | Found non-transient, non-static member. Please mark as transient or provide accessors.
69 | Local variable 'msg' could be declared final
73 | A method should have only one exit point, and that should be the last statement in the method
94 | Local variable 'msg' could be declared final
99 | Local variable 'msg' could be declared final
132 | Local variable 'buf' could be declared final
135 | Local variable 'in_nmap_a' could be declared final
195 | Avoid excessively long variable names like installationResults
200 | Avoid variables with short names like os
201 | Avoid variables with short names like in
240 | Avoid assignments in operands
240 | Found 'DU'-anomaly for variable 'input' (lines '240'-'265').
244 | Avoid assignments in operands
244 | Found 'DU'-anomaly for variable 'error' (lines '244'-'265').

src/com/wjholden/nmap/NmapMain.java
1 | A high number of imports can indicate a high degree of coupling within an object.
43 | The class 'NmapMain' has a Cyclomatic Complexity of 5 (Highest = 20).
43 | This class has too many methods, consider refactoring it.
43 | Too many fields
110 | Avoid variables with short names like sh
125 | Found non-transient, non-static member. Please mark as transient or provide accessors.
130 | Found non-transient, non-static member. Please mark as transient or provide accessors.
142 | Avoid variables with short names like pd
147 | Found non-transient, non-static member. Please mark as transient or provide accessors.
152 | Found non-transient, non-static member. Please mark as transient or provide accessors.
152 | Perhaps 'preferencesEditor' could be replaced by a local variable.
166 | Avoid variables with short names like ne
171 | Found non-transient, non-static member. Please mark as transient or provide accessors.
171 | Perhaps 'wifiManager' could be replaced by a local variable.
176 | Perhaps 'wifiInfo' could be replaced by a local variable.
179 | Avoid excessively long variable names like savedInstanceState
179 | Avoid really long methods.
179 | Parameter 'savedInstanceState' is not assigned and could be declared final
179 | The method 'onCreate' has a Cyclomatic Complexity of 20.
179 | The method onCreate() has an NPath complexity of 900
188 | Local variable 'target' could be declared final
192 | Local variable 'args' could be declared final
200 | The String literal "installVerified" appears 4 times in this file; the first occurrence is on line 200
202 | The String literal "hasRunOneScan" appears 4 times in this file; the first occurrence is on line 202
204 | The String literal "canGetRoot" appears 4 times in this file; the first occurrence is on line 204
230 | Local variable 'curVersion' could be declared final
252 | Avoid variables with short names like v
252 | Parameter 'v' is not assigned and could be declared final
257 | Avoid excessively long variable names like targetAndArguments
257 | Found 'DU'-anomaly for variable 'targetAndArguments' (lines '257'-'318').
257 | Found 'DU'-anomaly for variable 'targetAndArguments' (lines '257'-'318').
257 | Found 'DU'-anomaly for variable 'targetAndArguments' (lines '257'-'318').
257 | Found 'DU'-anomaly for variable 'targetAndArguments' (lines '257'-'318').
286 | Avoid variables with short names like v
286 | Parameter 'v' is not assigned and could be declared final
310 | Parameter 'v' is not assigned and could be declared final
322 | Avoid instantiating String objects; this is usually unnecessary.
327 | Avoid instantiating String objects; this is usually unnecessary.
344 | Avoid excessively long variable names like savedInstanceState
344 | Parameter 'savedInstanceState' is not assigned and could be declared final
352 | Avoid using if statements without curly braces
354 | Avoid using if statements without curly braces
428 | Local variable 'uri' could be declared final
442 | Local variable 'surveyActivity' could be declared final
519 | Avoid using if statements without curly braces
533 | Avoid really long methods.
533 | The method 'initHandler' has a Cyclomatic Complexity of 18.
537 | Avoid really long methods.
537 | The method 'handleMessage' has a Cyclomatic Complexity of 17.
539 | Found 'DU'-anomaly for variable 'alert' (lines '539'-'647').
539 | Found 'DU'-anomaly for variable 'alert' (lines '539'-'647').
539 | Found 'DU'-anomaly for variable 'alert' (lines '539'-'647').
545 | An empty statement (semicolon) not part of a loop
577 | Position literals first in String comparisons
581 | Position literals first in String comparisons
585 | Position literals first in String comparisons
603 | Avoid assignments in operands
603 | Found 'DU'-anomaly for variable 'line' (lines '603'-'647').
603 | Found 'DU'-anomaly for variable 'line' (lines '603'-'647').
603 | Found 'DU'-anomaly for variable 'line' (lines '603'-'647').

src/com/wjholden/nmap/NmapScan.java
25 | The class 'NmapScan' has a Cyclomatic Complexity of 10 (Highest = 21).
29 | Avoid variables with short names like os
29 | Perhaps 'os' could be replaced by a local variable.
30 | Avoid variables with short names like in
30 | Perhaps 'in' could be replaced by a local variable.
31 | Perhaps 'err' could be replaced by a local variable.
32 | Avoid variables with short names like p
32 | Perhaps 'p' could be replaced by a local variable.
78 | Avoid really long methods.
78 | The method 'doInBackground' has a Cyclomatic Complexity of 21.
78 | The method doInBackground() has an NPath complexity of 79872
80 | Found 'DU'-anomaly for variable 'exeParams' (lines '80'-'233').
88 | Found 'DU'-anomaly for variable 'temporaryFolder' (lines '88'-'233').
107 | A method should have only one exit point, and that should be the last statement in the method
120 | A method should have only one exit point, and that should be the last statement in the method
148 | Position literals first in String comparisons
149 | Avoid using if...else statements without curly braces
181 | Avoid assignments in operands
184 | Prefer StringBuffer over += for concatenating strings
188 | Local variable 'msg1' could be declared final
195 | Local variable 'msg' could be declared final
203 | Avoid assignments in operands
205 | Local variable 'msg' could be declared final
211 | Local variable 'msg' could be declared final
220 | Local variable 'msg' could be declared final
228 | Position literals first in String comparisons

src/com/wjholden/nmap/NmapSurvey.java
39 | Avoid excessively long variable names like savedInstanceState
39 | Parameter 'savedInstanceState' is not assigned and could be declared final
49 | Avoid variables with short names like v
49 | Parameter 'v' is not assigned and could be declared final
50 | Local variable 'myUploadData' could be declared final
72 | To be compliant to J2EE, a webapp should not use any thread.
77 | Found non-transient, non-static member. Please mark as transient or provide accessors.
82 | Found non-transient, non-static member. Please mark as transient or provide accessors.
87 | Found non-transient, non-static member. Please mark as transient or provide accessors.
97 | It is a good practice to call super() in a constructor
113 | Local variable 'client' could be declared final
114 | Local variable 'url' could be declared final
115 | Local variable 'uri' could be declared final
117 | Local variable 'httppost' could be declared final

src/com/wjholden/nmap/NmapUtilities.java
83 | Avoid instantiating new objects inside loops
108 | Found 'DD'-anomaly for variable 'dataDir' (lines '108'-'110').